use consistent read when deleting data #171
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Mar 7, 2025
Merged
Contributor
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. |
AmineAfia
approved these changes
Mar 9, 2025
iuwqyir
force-pushed
the
03-07-use_contract_api_as_a_fallback_for_decoding_if_signature_based_fails
branch
2 times, most recently
from
e9a8eb5 to
7c49c60
Compare
iuwqyir
force-pushed
the
03-07-use_consistent_read_when_deleting_data
branch
from
19d7309 to
b3862b4
Compare
iuwqyir
changed the base branch from
03-07-use_contract_api_as_a_fallback_for_decoding_if_signature_based_fails
to
graphite-base/171
iuwqyir
force-pushed
the
03-07-use_consistent_read_when_deleting_data
branch
from
b3862b4 to
d55e6be
Compare
iuwqyir
force-pushed
the
03-07-use_consistent_read_when_deleting_data
branch
from
d55e6be to
1f32c29
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TL;DR
Added
ForceConsistentData: trueto query filters in block deletion operations.What changed?
Modified the query filters in
deleteBlocks,deleteLogs,deleteTransactions, anddeleteTracesfunctions to includeForceConsistentData: trueparameter when retrieving data before deletion.How to test?
Why make this change?
Ensures data consistency during block deletion operations by forcing the query to return complete and consistent datasets before performing deletions. This prevents potential partial or inconsistent data deletions that could corrupt the database state.